search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Code split top level routes in defined in an Outlet #259

Closed agubler closed 4 years ago

agubler commented 4 years ago

Type: feature

The following has been addressed in the PR:

Description:

Updated to reflect the changes from @dojo/framework that changes the concept of an Outlet in Dojo. The existing Outlet behaviour is now available using Route and Outlet defines routes as keys in the children object.

Existing functionality for code-splitting updated from Outlet to Route. Added additional code-splitting based on the routes defined in outlet children.

Related to https://github.com/dojo/framework/issues/715

codecov[bot] commented 4 years ago

Codecov Report

Merging #259 into master will increase coverage by 0.17%. The diff coverage is 96.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   84.60%   84.78%   +0.17%     
==========================================
  Files          48       48              
  Lines        2170     2208      +38     
  Branches      571      585      +14     
==========================================
+ Hits         1836     1872      +36     
- Misses        334      336       +2
Impacted Files Coverage Δ
src/registry-transformer/index.ts 98.53% <96.72%> (-0.62%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65c8a8b...f64cc4a. Read the comment docs.