search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Allow blocks to change on watch #261

Closed agubler closed 4 years ago

agubler commented 4 years ago

Type: bug

The following has been addressed in the PR:

Description:

With on-demand BTR when javascript is enabled, if the result of the block changes but the arguments don't (common) then the new block content is not written. This tracks the blocks written per build and only adds the block entry if it doesn't already exist.

codecov[bot] commented 4 years ago

Codecov Report

Merging #261 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   85.23%   85.25%   +0.02%     
==========================================
  Files          49       49              
  Lines        2282     2286       +4     
  Branches      600      601       +1     
==========================================
+ Hits         1945     1949       +4     
  Misses        337      337
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 94.96% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e7e6e3...18ae399. Read the comment docs.