search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Replace requires with empty object instead of undefined #266

Closed agubler closed 4 years ago

agubler commented 4 years ago

Type: bug

The following has been addressed in the PR:

Description:

With requires they get used to reference by obj.default which means replacing the import with undefined leads to runtime errors for any checks on the elided import. For requires this should be an empty object, as default and named imports are referenced from an object.

codecov[bot] commented 4 years ago

Codecov Report

Merging #266 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files          49       49           
  Lines        2286     2286           
  Branches      601      601           
=======================================
  Hits         1949     1949           
  Misses        337      337
Impacted Files Coverage Δ
src/static-build-loader/loader.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1e65e5...930d61b. Read the comment docs.