dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

BTR parsing CSS to determine styles to inline does not work with class names with escaped colons #290

Closed agubler closed 4 years ago

agubler commented 4 years ago

Bug

The parsing used to determine the critical styles that should be inlined into the rendered output at build time is very basic and does not work with classnames that include : as everything after and including the first colon is removed (assumed a pseudo selector like hover or before etc). Also the parsing does not cater for >:not( or :~not( as it leaves the leading character such that the classes will not match any of the classes in the rendered output.