codecov[bot]
commented
4 years ago Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@6d7cc4e). Click here to learn what that means. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #303 +/- ##
=========================================
Coverage ? 85.73%
=========================================
Files ? 50
Lines ? 2369
Branches ? 631
=========================================
Hits ? 2031
Misses ? 338
Partials ? 0 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/electron-plugin/ElectronPlugin.ts | 100.00% <100.00%> (ø) |
|
| src/cldr/Plugin.ts | 100.00% <0.00%> (ø) |
|
| src/static-build-loader/getFeatures.ts | 91.30% <0.00%> (ø) |
|
| src/webpack-bundle-analyzer/tree/utils.ts | 100.00% <0.00%> (ø) |
|
| src/build-time-render/blocks.js | 0.00% <0.00%> (ø) |
|
| ...8n-plugin/dependencies/InjectedModuleDependency.ts | 100.00% <0.00%> (ø) |
|
| src/bootstrap-plugin/common.js | 0.00% <0.00%> (ø) |
|
| src/bootstrap-plugin/BootstrapPlugin.ts | 100.00% <0.00%> (ø) |
|
| src/build-time-render/BuildTimeRenderMiddleware.ts | 100.00% <0.00%> (ø) |
|
| src/static-build-loader/index.ts | 100.00% <0.00%> (ø) |
|
| ... and 41 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6d7cc4e...14bdbd5. Read the comment docs.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Reverting electron packaging removal. After the build, the electron app will be packaged!
Linked to https://github.com/dojo/cli-build-app/issues/356