search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Do not statically set fetch to true in modern #317

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

This change removes fetch from the modern feature set and allows the has sniff to work dynamically at runtime - this is inline with the other browser api shims such as intersection observer as they shims are split into sep bundles and only loaded for a user if the application uses the shim and the users environment requires the the shim.

This should resolve issues with build time rendering when an application imports dojo's fetch shim.

codecov[bot] commented 3 years ago

Codecov Report

Merging #317 (a4e576a) into master (b60450f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   85.64%   85.64%           
=======================================
  Files          54       54           
  Lines        2578     2578           
  Branches      694      694           
=======================================
  Hits         2208     2208           
  Misses        370      370

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b60450f...a4e576a. Read the comment docs.