search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Do not consider polyfills as additional scripts #323

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

We should not be preloading polyfills as they are determined by clients browser. Preloading means that unnecessary scripts would be loaded for every user.

codecov[bot] commented 3 years ago

Codecov Report

Merging #323 (abe782d) into master (a68d62e) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   85.48%   85.50%   +0.02%     
==========================================
  Files          54       54              
  Lines        2583     2587       +4     
  Branches      696      699       +3     
==========================================
+ Hits         2208     2212       +4     
  Misses        375      375
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 93.72% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a68d62e...abe782d. Read the comment docs.