search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

JSDom as default renderer for BTR #325

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: feature

The following has been addressed in the PR:

Description:

Jsdom covers most of the needs for BTR and us substantially faster, this changes the default renderer to be jsdom and makes puppeteer optional. If a user wants to use the puppeteer then they will need to install the dependency otherwise the build will fail.

codecov[bot] commented 3 years ago

Codecov Report

Merging #325 (67aa142) into master (99e537d) will decrease coverage by 0.03%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   85.50%   85.47%   -0.04%     
==========================================
  Files          54       54              
  Lines        2587     2588       +1     
  Branches      699      699              
==========================================
  Hits         2212     2212              
- Misses        375      376       +1
Impacted Files Coverage Δ
src/build-time-render/Renderer.ts 91.30% <75.00%> (-1.35%) :arrow_down:
src/build-time-render/BuildTimeRender.ts 93.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99e537d...67aa142. Read the comment docs.