search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Adjust serve for BTR to always fallback to history when path not found #328

Closed KaneFreeman closed 3 years ago

KaneFreeman commented 3 years ago

Type: feature

Previous Behavior: Urls ending in a file like path (containing a . in the last segment) that did not resolve to existing files returned a 404 error. This is the same behavior observed in cli-build-app.

New Behavior: Any path resulting in a 404 will default back to the history API, including file like paths (containing a . in the last segment).

The following has been addressed in the PR:

Description:

Resolves #326

codecov[bot] commented 3 years ago

Codecov Report

Merging #328 (aa876f7) into master (3641d4a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files          54       54           
  Lines        2592     2592           
  Branches      703      703           
=======================================
  Hits         2216     2216           
  Misses        376      376

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3641d4a...aa876f7. Read the comment docs.