search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Move request counter to instance variable of the custom resource class #332

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

There are occasions when the request counter can get to negative value which means that a page incorrectly times out. The request counter should always have been an instance variable, this moves the class out of the renderer and makes the counter an instance variable so it is isolated to each page visit.

codecov[bot] commented 3 years ago

Codecov Report

Merging #332 (6b2f7ad) into master (8200000) will increase coverage by 0.01%. The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   85.43%   85.45%   +0.01%     
==========================================
  Files          54       54              
  Lines        2596     2599       +3     
  Branches      704      704              
==========================================
+ Hits         2218     2221       +3     
  Misses        378      378
Impacted Files Coverage Δ
src/build-time-render/Renderer.ts 91.66% <82.35%> (+0.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8200000...6b2f7ad. Read the comment docs.