KaneFreeman commented 3 years ago

Type: bug

The following has been addressed in the PR:

[x] There is a related issue
[x] All code has been formatted with prettier as per the readme code style guidelines
[ ] Unit or Functional tests are included in the PR

Description: Update blocks.js file hash from manifest before writing index file

Resolves #289

codecov[bot] commented 3 years ago

Codecov Report

Merging #337 (1ab6e7f) into master (5785857) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files          54       54           
  Lines        2619     2619           
  Branches      715      715           
=======================================
  Hits         2240     2240           
  Misses        379      379

Impacted Files	Coverage Δ
src/build-time-render/BuildTimeRender.ts	`93.78% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5785857...1ab6e7f. Read the comment docs.

msssk commented 3 years ago

Is this good to merge and release?

dojo / webpack-contrib

Update blocks.js file hash from manifest before writing index file #337

Codecov Report