search

dojo / webpack-contrib

Plugins and loaders for webpack used with Dojo
Other
4 stars 19 forks source link

Fix acorn error that manifested using npm 7 or higher #341

Closed agubler closed 2 years ago

agubler commented 2 years ago

Type: bug

The following has been addressed in the PR:

Description:

An error occurs from acorn (SyntaxError: Unexpected token (8:17)) when dependencies are installed with npm 7 or higher, an outdated version of acorn is installed into the root of the project instead of the required 7.4.1 version.

This is due to the now redundant acorn plugin acorn-dynamic-import and once removed and the appropriate emcaVersion specified fixes the incorrect version of acorn being installed.

This is exposes another outdated dependency issue with ast-types which itself is a dependency of recast, the recast version is outdated and can be updated to a compatible version for both acorn and ast-types which resolves the issues.

Also includes an update to @types/babel-types which addresses issue https://github.com/dojo/cli-build-app/issues/475

Resolves #339

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers are authorized under a signed CLA.

codecov[bot] commented 2 years ago

Codecov Report

Merging #341 (3ca0cfa) into master (386c7a6) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   85.52%   85.52%   -0.01%     
==========================================
  Files          54       54              
  Lines        2619     2618       -1     
  Branches      715      715              
==========================================
- Hits         2240     2239       -1     
  Misses        379      379
Impacted Files Coverage Δ
src/static-build-loader/loader.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 386c7a6...3ca0cfa. Read the comment docs.