search

dojo / widget-core

:rocket: Dojo 2 - widget authoring system.
http://dojo.io
Other
34 stars 39 forks source link

Remove `FormLabel` from Mixins #405

Closed tomdye closed 7 years ago

tomdye commented 7 years ago

Enhancement

As we have taken a label widget direction in widgets I believe we should now remove theFormLabel mixin before beta release to avoid confusion for early adopters.

bitpshr commented 7 years ago

Agreed. We really need to pull out the shared properties for form components for beta 2 though.

agubler commented 7 years ago

@bitpshr Agreed. Do you think it that there will be a "base" properties interface and base abstract form class that get extended? Perhaps we can raise an issue in @dojo/widgets?

tomdye commented 7 years ago

Yes @bitpshr , as I believe we discussed when we moved to the label approach. We'll identify shared properties for form fields etc... slightly further down the line such that we don't over engineer / complicate things before we need to.