[x] Unit or Functional tests are included in the PR
Description:
vdom.ts was processing widgets that had been detached by a previous render but had been invalidated themselves and therefore were already on the queue. To resolve this the call to "detach" widgets has been moved from request idle callback to be sync when processing renders. When a node it removed, onDetach is called which removes all references such as an injector that would otherwise invalidate the detached widget and also removes the instance from the instanceMap so that it will not get rendered again.
Also when processing nodes from higher in the dnode tree, there was a possibility that an incorrect reference (to the old node) could be used as the render process was traversing down the tree of the parent stored at the point of time it was rendered. If the lower component had rendered itself since the reference the node had in it's tree would be outdated. This changes update children to always look for a node from the instanceMap as that will always be the latest version of the widget and used this for processing removal.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
vdom.tswas processing widgets that had been detached by a previous render but had been invalidated themselves and therefore were already on the queue. To resolve this the call to "detach" widgets has been moved from request idle callback to be sync when processing renders. When a node it removed,onDetachis called which removes all references such as an injector that would otherwise invalidate the detached widget and also removes the instance from theinstanceMapso that it will not get rendered again.Also when processing nodes from higher in the dnode tree, there was a possibility that an incorrect reference (to the old node) could be used as the render process was traversing down the tree of the parent stored at the point of time it was rendered. If the lower component had rendered itself since the reference the node had in it's tree would be outdated. This changes
updatechildren to always look for a node from theinstanceMapas that will always be the latest version of the widget and used this for processing removal.