Fixes Svg(path, rect, ellipse, line) is not draggable

dojo / widget-core

:rocket: Dojo 2 - widget authoring system.

http://dojo.io

Other

34 stars 39 forks source link

Fixes Svg(path, rect, ellipse, line) is not draggable #927

Closed SagarKharche closed 6 years ago

SagarKharche commented 6 years ago

Bug:- SVG element is not able to drag in IE 11.

The following has been addressed in the PR: Fixed the svg dragging issue in IE11. IE 11 does not support parentElement for SVGElement, so in case of parentElement undefined now checking for parentNode.

jsf-clabot commented 6 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

sagar.kharche@synerzip.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

agubler commented 6 years ago

Surprising as prettier should have formatted the file on commit.

We do need a test to cover these changes please.

SagarKharche commented 6 years ago

Closing this PR because of author email address is my wrong in commit