search

dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
89 stars 65 forks source link

trigger-popup: trigger node should have a themeable class #1604

Open msssk opened 3 years ago

msssk commented 3 years ago

Bug

The trigger node of trigger-popup should have a themeable class applied to it: https://github.com/dojo/widgets/blob/a3fdfc3216aec67fb4cdb794906379b91c7796bb/src/trigger-popup/index.tsx#L59

Also does classes have any effect on virtual? https://github.com/dojo/widgets/blob/a3fdfc3216aec67fb4cdb794906379b91c7796bb/src/trigger-popup/index.tsx#L58

Package Version: 7.0.3, 8.0.0

tomdye commented 3 years ago

What would the trigger class be used for? it's just a wrapper for what ever triggers the popup in order to calculate size etc. Any theming should be done on that item that's wrapped itself?

agubler commented 3 years ago

@tomdye I believe this was kind of covered by https://github.com/dojo/widgets/pull/1673, it changed the trigger to 100% width which means that it can now be constrained by the consumer (rather than overriding the size)