dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
89 stars 65 forks source link

Bug: Fixes non-strict Typeahead behaviour related to onValue and validation #1622

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

Fixes issues relating to the Typeahead non-strict behaviour

Resolves #1620 Resolves #1621

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojowidgets/cy1awyfti
βœ… Preview: https://dojowidgets-git-fork-agubler-typeahead-validation-non-strict.dojo1.vercel.app

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/kev3at0hg
βœ… Preview: https://widget-test-do-git-fork-agubler-typeahead-validation-non-7b01ec.dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1622 (73b4406) into master (a754558) will increase coverage by 0.09%. The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
+ Coverage   89.97%   90.07%   +0.09%     
==========================================
  Files          94       94              
  Lines        4897     4906       +9     
  Branches     1316     1323       +7     
==========================================
+ Hits         4406     4419      +13     
  Misses        244      244              
+ Partials      247      243       -4     
Impacted Files Coverage Ξ”
src/typeahead/index.tsx 85.71% <93.33%> (+2.60%) :arrow_up:
src/date-input/index.tsx 94.28% <0.00%> (-0.82%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update a754558...73b4406. Read the comment docs.