Closed agubler closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
π Inspect: https://vercel.com/dojo/widget-test-docs/1djbtke2u
β
Preview: https://widget-test-docs-git-fork-agubler-remove-tab-controller-style.dojo1.vercel.app
π Inspect: https://vercel.com/dojo/dojowidgets/i9yw23bfy
β
Preview: https://dojowidgets-git-fork-agubler-remove-tab-controller-style.dojo1.vercel.app
Merging #1660 (7d6a604) into master (c424ca6) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1660 +/- ##
=======================================
Coverage 90.11% 90.11%
=======================================
Files 94 94
Lines 4907 4907
Branches 1328 1328
=======================================
Hits 4422 4422
Misses 243 243
Partials 242 242
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update c424ca6...bdc6001. Read the comment docs.
Type: bug
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
Originally it was correct to remove the tab-content styles from the content, it was just not right to put them into the tab content style that is used. this has a weird flex with justify centre that is not required for tab content, so removing it completely resolves that and the pointer events and also keeps the tabs styled correctly.