dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
89 stars 65 forks source link

Fix setting values in date input and time picker when submitting as part of the form #1666

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

When using the inputs as part of a form the setting of the values on "Enter" was actually done on the next render, which meant that the submit of the form happened with "stale" data before it was updated. This changes to set the value immediately so it is correct for a form submission

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/pnkpksgbx
βœ… Preview: https://widget-test-docs-git-fork-agubler-date-input-in-form.dojo1.now.sh

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojowidgets/ntl5o1zcb
βœ… Preview: https://dojowidgets-git-fork-agubler-date-input-in-form.dojo1.now.sh

codecov[bot] commented 3 years ago

Codecov Report

Merging #1666 (b05fba6) into master (92b6e1f) will decrease coverage by 0.04%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
- Coverage   89.90%   89.85%   -0.05%     
==========================================
  Files          94       94              
  Lines        4951     4950       -1     
  Branches     1339     1336       -3     
==========================================
- Hits         4451     4448       -3     
- Misses        247      248       +1     
- Partials      253      254       +1     
Impacted Files Coverage Ξ”
src/date-input/index.tsx 90.65% <63.63%> (-1.94%) :arrow_down:
src/time-picker/index.tsx 81.81% <80.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 92b6e1f...21b8f89. Read the comment docs.