dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
89 stars 66 forks source link

Add leading/trailing example for NumberInput #1671

Closed aciccarello closed 3 years ago

aciccarello commented 3 years ago

Type: feature

The following has been addressed in the PR:

Description: This adds a leading/trailing example for the number input widget.

Relates to #1578 which indicated a styling issue with the NumberInput

Dojo theme number input example Material theme number input example Material dark theme number input example

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/5S9MzJ8XyHXyggqnu1jztM8tkJsR
βœ… Preview: https://widget-test-docs-git-fork-aciccarello-1578-number-leading-dojo1.vercel.app

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/Ej9rfF9JvwHvq3pk4H2jvRcKttGf
βœ… Preview: https://dojowidgets-git-fork-aciccarello-1578-number-leading-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1671 (acd06da) into master (eeefd52) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1671   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          94       94           
  Lines        4963     4963           
  Branches     1342     1342           
=======================================
  Hits         4461     4461           
  Misses        248      248           
  Partials      254      254           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update eeefd52...acd06da. Read the comment docs.

agubler commented 3 years ago

Thanks @aciccarello, can you close the issue when you merge this too please?