dojo / widgets

:rocket: Dojo - UI widgets.

https://widgets.dojo.io

Other

88 stars 66 forks source link

Allow the slidepane title to be a render result #1675

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: feature

The following has been addressed in the PR:

[ ] There is a related issue
[ ] All code matches the style guide
[ ] Unit tests are included in the PR
[ ] For new widgets, an entry has been added to the .dojorc
[ ] For new widgets, theme.variant() is added to the root domnode
[ ] Any widget variant uses theme.compose like this
[ ] WidgetProperties are exported

Description:

Changes the title for the slidepane to be a child over a property so that a render result can be used.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/HxMi74r9y8UomGvnpmxMmgRxCLA7
✅ Preview: https://dojowidgets-git-fork-agubler-slide-pane-title-dojo1.vercel.app

[Deployment for 10c21b7 failed]

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/54UFMNy62ZA3JNCj5voh37EPCTu2
✅ Preview: https://widget-test-docs-git-fork-agubler-slide-pane-title-dojo1.vercel.app

[Deployment for 10c21b7 failed]

codecov[bot] commented 3 years ago

Codecov Report

Merging #1675 (5beef58) into master (eeefd52) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1675   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          94       94           
  Lines        4963     4964    +1     
  Branches     1342     1342           
=======================================
+ Hits         4461     4462    +1     
  Misses        248      248           
  Partials      254      254

Impacted Files	Coverage Δ
src/slide-pane/index.tsx	`87.39% <100.00%> (+0.10%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eeefd52...1607d31. Read the comment docs.