dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

Calculate the size of rows correctly #1676

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

Enables calculating the size of rows correctly for material, this removes the fixed height of the row items and changes to a min height which enables custom list items. Also it splits the padding and the other styles from the list root so the list root can be applied when doing the offscreen render as it contains styles that affect the size (from the material styles).

In future the list should not affect the list item styles at all.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/6V9F2qQcqDJNavE2ztjW43F8UwmK
βœ… Preview: https://dojowidgets-git-fork-agubler-size-list-rows-correctly-dojo1.vercel.app

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/6CTyQoYypBKnaffL78rhWWby2D4K
βœ… Preview: https://widget-test-do-git-fork-agubler-size-list-rows-correctl-be4bc6.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1676 (0399a68) into master (eeefd52) will increase coverage by 0.00%. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1676   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          94       94           
  Lines        4963     4965    +2     
  Branches     1342     1342           
=======================================
+ Hits         4461     4463    +2     
  Misses        248      248           
  Partials      254      254           
Impacted Files Coverage Ξ”
src/list/index.tsx 77.77% <50.00%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update eeefd52...ec862f5. Read the comment docs.