Closed agubler closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
π Inspect: https://vercel.com/dojo/widget-test-docs/4Yy9H5k7JxpBEiZgSedUXyKLYucZ
β
Preview: https://widget-test-docs-git-fork-agubler-fill-items-for-list-dojo1.vercel.app
π Inspect: https://vercel.com/dojo/dojo.widgets/46Uw7poNPTC4AB76EpPrSD8Yp8Ee
β
Preview: https://dojowidgets-git-fork-agubler-fill-items-for-list-dojo1.vercel.app
Merging #1677 (9a456b8) into master (9e5b5db) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1677 +/- ##
==========================================
+ Coverage 90.01% 90.05% +0.04%
==========================================
Files 94 94
Lines 5036 5050 +14
Branches 1368 1373 +5
==========================================
+ Hits 4533 4548 +15
Misses 249 249
+ Partials 254 253 -1
Impacted Files | Coverage Ξ | |
---|---|---|
src/list/index.tsx | 79.94% <100.00%> (+1.19%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 9e5b5db...9a456b8. Read the comment docs.
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
If would be nice if the list could offer a mode that would fill the available space (height) with as many items that fit, instead of having to provide a number of items to render. The is issue is, that the list itself does the list item height calculation so as a user we'd have to duplicate that to calculated how many items could be visible in the space.
The other option would be to pass a "height" property that gives the list the height and then uses that to determine how many items should be in view.