dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

Ensure that a popup is not inert which can happen when rendered inside a dialog #1685

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

The Dialog uses the inert middleware which sets everything other than the Dialog and it's children as inert (i.e. disabled). This is problematic when using a widget that uses the body tag as it's not a child to the dialog and therefore is set to inert - The example is using a typeahead in the dialog, that renders a list into the popup. This change to the popup sets it as always not inert.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/CgfHQ3gXdGUw5P5sQdu5NopGVWeQ
βœ… Preview: https://widget-test-do-git-fork-agubler-popup-should-not-be-iner-f19edd.vercel.app

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/8zQP3dD2ywzGGNNMFnsBCemrB2tZ
βœ… Preview: https://dojowidgets-git-fork-agubler-popup-should-not-be-inert-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1685 (dad3da2) into master (34141dd) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1685   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files          94       94           
  Lines        5012     5014    +2     
  Branches     1354     1354           
=======================================
+ Hits         4510     4512    +2     
  Misses        248      248           
  Partials      254      254           
Impacted Files Coverage Ξ”
src/popup/index.tsx 96.15% <100.00%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 34141dd...dad3da2. Read the comment docs.