dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
89 stars 66 forks source link

feat: SpeedDial action label support #1686

Closed bitpshr closed 3 years ago

bitpshr commented 3 years ago

Type: feature

The following has been addressed in the PR:

Description:

This pull request adds label support for SpeedDial actions.

preview

Resolves #1572

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/FYzkdxFZVYRmwCCkhLv7o9bvhnsT
✅ Preview: https://dojowidgets-git-fork-bitpshr-feat-speeddial-action-labels-dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/AWHhWvDk3RsWdysQRuRPfwky9X1y
✅ Preview: https://widget-test-do-git-fork-bitpshr-feat-speeddial-action-la-c6a08e.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1686 (662256b) into master (ebbad1b) will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
+ Coverage   89.98%   90.17%   +0.18%     
==========================================
  Files          94       94              
  Lines        5012     5088      +76     
  Branches     1354     1384      +30     
==========================================
+ Hits         4510     4588      +78     
+ Misses        248      247       -1     
+ Partials      254      253       -1     
Impacted Files Coverage Δ
src/speed-dial/index.tsx 97.43% <100.00%> (+5.30%) :arrow_up:
src/loading-indicator/index.tsx 88.46% <0.00%> (-11.54%) :arrow_down:
src/common/tests/support/test-helpers.ts 93.18% <0.00%> (-6.82%) :arrow_down:
src/text-input/index.tsx 92.68% <0.00%> (-0.24%) :arrow_down:
src/card/index.tsx 100.00% <0.00%> (ø)
src/tooltip/index.tsx 77.41% <0.00%> (ø)
src/date-input/index.tsx 91.07% <0.00%> (ø)
src/time-picker/index.tsx 81.81% <0.00%> (ø)
src/action-button/index.tsx 100.00% <0.00%> (ø)
src/raised-button/index.tsx 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebbad1b...662256b. Read the comment docs.

tomdye commented 3 years ago

@bitpshr My only comment is that it might be more appropriate to use an label node for the label than a div. At the very least, it likely needs some aria attributes to link it to the button etc.

tomdye commented 3 years ago

It looks like most of the innards of Action are untested atm, do you think it would be worth adding some tests around those?

tomdye commented 3 years ago

@bitpshr I think it's still worth adding a test here for the action render otherwise the label functionality is entirely untested, hence why the aria-aria bug got through.