dojo / widgets

:rocket: Dojo - UI widgets.

https://widgets.dojo.io

Other

88 stars 66 forks source link

feat: easier FloatingActionButton theming #1687

Closed bitpshr closed 3 years ago

bitpshr commented 3 years ago

Type: feature

The following has been addressed in the PR:

[x] There is a related issue
[x] All code matches the style guide
[x] Unit tests are included in the PR
[x] For new widgets, an entry has been added to the .dojorc
[x] For new widgets, theme.variant() is added to the root domnode
[x] Any widget variant uses theme.compose like this
[x] WidgetProperties are exported

Description:

This pull request uses variables that are specific to the FloatingActionButton so that basic theming (background color and text color, for now) is easier. Previously, Button defaults were used, which prevented buttons and FABs from being themed independently.

Resolves #1649

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/CenEXHu91YNeMRuxwNpoNw4HszCu
✅ Preview: https://dojowidgets-git-feat-fab-theme-customize-dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/5EUyQshiDxaTPiVJ6fpyRFn5myNn
✅ Preview: https://widget-test-docs-git-feat-fab-theme-customize-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1687 (f1016fa) into master (087d465) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1687   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files          94       94           
  Lines        5031     5031           
  Branches     1364     1364           
=======================================
  Hits         4526     4526           
  Misses        249      249           
  Partials      256      256

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 087d465...f1016fa. Read the comment docs.