dojo / widgets

:rocket: Dojo - UI widgets.

https://widgets.dojo.io

Other

88 stars 66 forks source link

add leading and trailing to listitem widget #1690

Closed aciccarello closed 3 years ago

aciccarello commented 3 years ago

Type: feature

The following has been addressed in the PR:

[x] There is a related issue
[x] All code matches the style guide
[x] Unit tests are included in the PR
[ ] For new widgets, an entry has been added to the .dojorc
[ ] For new widgets, theme.variant() is added to the root domnode
[ ] Any widget variant uses theme.compose like this
[x] WidgetProperties are exported

Description: Changes ListItem widget to take leading, trailing, and primary child properites. If a RenderResult is passed, it is rendered as the primary content.

Resolves #1570

list item renderer example page with dojo theme

list item renderer example page with material theme

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/EapjXZUJLiQuJ2uaZGfM1xhJG5ub
✅ Preview: https://dojowidgets-git-fork-aciccarello-1570-listitem-widget-dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/FP4WmxG8ZnD5Fwe1rw9Ru8JPkchV
✅ Preview: https://widget-test-do-git-fork-aciccarello-1570-listitem-widge-2d4273.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1690 (63c63eb) into master (087d465) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
+ Coverage   89.96%   90.01%   +0.04%     
==========================================
  Files          94       94              
  Lines        5031     5036       +5     
  Branches     1364     1368       +4     
==========================================
+ Hits         4526     4533       +7     
  Misses        249      249              
+ Partials      256      254       -2

Impacted Files	Coverage Δ
src/list/index.tsx	`78.75% <100.00%> (+0.97%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 087d465...63c63eb. Read the comment docs.