search

dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

Remove text-input `Addon` widget #1697

Closed tomdye closed 3 years ago

tomdye commented 3 years ago

This PR removes the text-input Addon widget and makes it more user friendly. You can now simply pass the leading / trailing dom node directly to the TextInput.

Resolves: #1695

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/Gy92jP8wXeaM1hngYtN56vyugqDk
✅ Preview: https://widget-test-docs-git-fork-tomdye-text-input-addon-dojo1.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/CyftXDNLsmxAsevtD41My821D5Va
✅ Preview: https://dojowidgets-git-fork-tomdye-text-input-addon-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1697 (316a470) into master (8bade73) will decrease coverage by 0.00%. The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
- Coverage   90.05%   90.05%   -0.01%     
==========================================
  Files          94       94              
  Lines        5050     5046       -4     
  Branches     1373     1374       +1     
==========================================
- Hits         4548     4544       -4     
  Misses        249      249              
  Partials      253      253
Impacted Files Coverage Δ
src/password-input/index.tsx 78.57% <40.00%> (ø)
src/date-input/index.tsx 91.07% <100.00%> (ø)
src/text-input/index.tsx 92.68% <100.00%> (-0.24%) :arrow_down:
src/time-picker/index.tsx 81.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8bade73...316a470. Read the comment docs.

samends commented 3 years ago

Looks good Tom! What was the original thought behind the Addon widget?

tomdye commented 3 years ago

Looks good Tom! What was the original thought behind the Addon widget?

I believe it was to make the padding optional but this can be done better via theming etc now. The previous approach was awkward for custom elements.

tomdye commented 3 years ago

@aciccarello comments addressed