dojo / widgets

:rocket: Dojo - UI widgets.

https://widgets.dojo.io

Other

88 stars 66 forks source link

make card expand to parent height and width #1701

Closed aciccarello closed 3 years ago

aciccarello commented 3 years ago

Type: bug / feature

The following has been addressed in the PR:

[x] There is a related issue
[x] All code matches the style guide
[ ] Unit tests are included in the PR
[ ] For new widgets, an entry has been added to the .dojorc
[ ] For new widgets, theme.variant() is added to the root domnode
[ ] Any widget variant uses theme.compose like this
[ ] WidgetProperties are exported

Description: Makes card widget default to full width. The card content section will expand to fill any empty space so that the action buttons remain on the bottom.

Resolves #1693

Screenshots with height and width set on parent: card basic action example material theme card header content media and actions example with material theme card basic action example with dojo theme

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/CS74CuQxhrw3fJp1yhC751ZqUhq1
✅ Preview: https://dojowidgets-git-fork-aciccarello-1693-card-size-dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/HB6zNJ9geFMrSgtAVyu7yYxSSVe3
✅ Preview: https://widget-test-docs-git-fork-aciccarello-1693-card-size-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1701 (fff1c92) into master (8bade73) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1701   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files          94       94           
  Lines        5050     5050           
  Branches     1373     1373           
=======================================
  Hits         4548     4548           
  Misses        249      249           
  Partials      253      253

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8bade73...fff1c92. Read the comment docs.