dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

fix: disabled input backgrounds #1703

Closed bitpshr closed 3 years ago

bitpshr commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

This pull request consolidates disabled backgrounds between Select and other inputs. A few different underlying issues caused the difference in background color: Select used an unnecessary explicit background color, and Input incorrectly applied background styles.

Resolves #1703

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/6avfeTxAzF7fFDmpYWymAuRn9XHE
βœ… Preview: https://dojowidgets-git-fork-bitpshr-fix-disabled-input-bg-dojo1.vercel.app

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/ibm927tUn4CCuVZ4c8s3GA3sqxP3
βœ… Preview: https://widget-test-docs-git-fork-bitpshr-fix-disabled-input-bg-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1703 (478b76b) into master (ce182a0) will increase coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
+ Coverage   89.96%   90.07%   +0.11%     
==========================================
  Files          94       94              
  Lines        5031     5050      +19     
  Branches     1364     1373       +9     
==========================================
+ Hits         4526     4549      +23     
  Misses        249      249              
+ Partials      256      252       -4     
Impacted Files Coverage Ξ”
src/tooltip/index.tsx 77.41% <0.00%> (ΓΈ)
src/select/index.tsx 86.95% <0.00%> (+0.86%) :arrow_up:
src/list/index.tsx 79.94% <0.00%> (+2.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ce182a0...478b76b. Read the comment docs.

bitpshr commented 3 years ago

Closing in favor of #1702.