Closed bitpshr closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
π Inspect: https://vercel.com/dojo/dojo.widgets/6avfeTxAzF7fFDmpYWymAuRn9XHE
β
Preview: https://dojowidgets-git-fork-bitpshr-fix-disabled-input-bg-dojo1.vercel.app
π Inspect: https://vercel.com/dojo/widget-test-docs/ibm927tUn4CCuVZ4c8s3GA3sqxP3
β
Preview: https://widget-test-docs-git-fork-bitpshr-fix-disabled-input-bg-dojo1.vercel.app
Merging #1703 (478b76b) into master (ce182a0) will increase coverage by
0.11%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
+ Coverage 89.96% 90.07% +0.11%
==========================================
Files 94 94
Lines 5031 5050 +19
Branches 1364 1373 +9
==========================================
+ Hits 4526 4549 +23
Misses 249 249
+ Partials 256 252 -4
Impacted Files | Coverage Ξ | |
---|---|---|
src/tooltip/index.tsx | 77.41% <0.00%> (ΓΈ) |
|
src/select/index.tsx | 86.95% <0.00%> (+0.86%) |
:arrow_up: |
src/list/index.tsx | 79.94% <0.00%> (+2.16%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update ce182a0...478b76b. Read the comment docs.
Closing in favor of #1702.
Type: bug
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
This pull request consolidates disabled backgrounds between
Select
and other inputs. A few different underlying issues caused the difference in background color:Select
used an unnecessary explicit background color, andInput
incorrectly applied background styles.Resolves #1703