dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

Adds circular loader #1706

Closed samends closed 3 years ago

samends commented 3 years ago

Type: feature

The following has been addressed in the PR:

Description: Adds circular loader to LoadingIndicator widget

Resolves #1584

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/EgWAHYJKsAYTwJC3Kh7osohJsdUV
✅ Preview: https://widget-test-docs-git-fork-samends-circular-loader-dojo1.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/3qgXf2ui4nAkmtBWUHukpa5ndu4v
✅ Preview: https://dojowidgets-git-fork-samends-circular-loader-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1706 (59026ab) into master (8bade73) will decrease coverage by 0.01%. The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1706      +/-   ##
==========================================
- Coverage   90.05%   90.03%   -0.02%     
==========================================
  Files          94       94              
  Lines        5050     5060      +10     
  Branches     1373     1379       +6     
==========================================
+ Hits         4548     4556       +8     
- Misses        249      251       +2     
  Partials      253      253              
Impacted Files Coverage Δ
src/loading-indicator/index.tsx 88.46% <81.25%> (-11.54%) :arrow_down:
src/text-input/index.tsx 92.68% <0.00%> (-0.24%) :arrow_down:
src/date-input/index.tsx 91.07% <0.00%> (ø)
src/time-picker/index.tsx 81.81% <0.00%> (ø)
src/password-input/index.tsx 78.57% <0.00%> (ø)
src/chip-typeahead/index.tsx 89.71% <0.00%> (+0.09%) :arrow_up:
src/select/index.tsx 86.95% <0.00%> (+0.86%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8bade73...59026ab. Read the comment docs.

tomdye commented 3 years ago

@samends Looks like you've addressed Ant's concerns but I believe it would benefit from having the different sizes examples added to the circular indicator example please.