dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

The content wrapper needs to be height 100% #1707

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

To support content using height 100% the content wrapper needs to have height 100%.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/2vWUnb9CGFzVes669MocvsUurNj3
βœ… Preview: https://dojowidgets-git-fork-agubler-full-height-on-content-w-59144d.vercel.app

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/6fsR2PpSQDNSsXtgsMXM9hAqAdV2
βœ… Preview: https://widget-test-do-git-fork-agubler-full-height-on-content-w-3ab7b8.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1707 (24d09f1) into master (6b9d384) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1707   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          94       94           
  Lines        5046     5046           
  Branches     1374     1374           
=======================================
  Hits         4545     4545           
  Misses        249      249           
  Partials      252      252           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 6b9d384...24d09f1. Read the comment docs.