Closed samends closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/dojo/widget-test-docs/Co9aD7FU4AngBZ5uWiqsigigPRwK
✅ Preview: https://widget-test-docs-git-fork-samends-disabled-group-dojo1.vercel.app
🔍 Inspect: https://vercel.com/dojo/dojo.widgets/BBDVxD7YornfuGsigSVWkq9Zhasp
✅ Preview: https://dojowidgets-git-fork-samends-disabled-group-dojo1.vercel.app
Merging #1711 (ca02744) into master (8bade73) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1711 +/- ##
==========================================
+ Coverage 90.05% 90.07% +0.01%
==========================================
Files 94 94
Lines 5050 5047 -3
Branches 1373 1375 +2
==========================================
- Hits 4548 4546 -2
Misses 249 249
+ Partials 253 252 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/checkbox-group/index.tsx | 100.00% <100.00%> (ø) |
|
src/radio-group/index.tsx | 100.00% <100.00%> (ø) |
|
src/text-input/index.tsx | 92.68% <0.00%> (-0.24%) |
:arrow_down: |
src/date-input/index.tsx | 91.07% <0.00%> (ø) |
|
src/time-picker/index.tsx | 81.81% <0.00%> (ø) |
|
src/password-input/index.tsx | 78.57% <0.00%> (ø) |
|
src/chip-typeahead/index.tsx | 89.71% <0.00%> (+0.09%) |
:arrow_up: |
src/select/index.tsx | 86.95% <0.00%> (+0.86%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8bade73...ca02744. Read the comment docs.
@samends , Im not sure this does what the ticket referred to which was a top level disabled
property to disable all checkboxes / radios in a group.
We should add a top level disabled?: boolean property that can be used to disable all inputs within the group.
@tomdye should we keep the individual disable property? I can also add a top level disable
@tomdye @samends I think this should be just a top level disable, for more complex functionality users can implement their own custom renderer.
Superseded by #1745
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
disabled
field toRadioGroup
options
propertydisabled
field toCheckboxGroup
options
propertyResolves #1698