dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
89 stars 66 forks source link

Feature/action groups - 1574 #1713

Closed KaneFreeman closed 3 years ago

KaneFreeman commented 3 years ago

Type: feature

The following has been addressed in the PR:

All widgets with "actions" have been switched to the same pattern established by Speed Dial, an internal action widget specialized to that widget. Most do not do anything beyond wrapping ActionButton, Link and Icon but create a basis for expanding upon later on.

Description:

Resolves #1574

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/3pPZBP7bQSDfUQBuL3fXsUK5GaGn
✅ Preview: https://widget-test-do-git-fork-kanefreeman-feature-action-group-01d9d0.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/7JSTF7TG6eWWXd3qv83B6Q5Rn9mo
✅ Preview: https://dojowidgets-git-fork-kanefreeman-feature-action-groups-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1713 (c5b55c8) into master (650a556) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   90.07%   90.10%   +0.03%     
==========================================
  Files          94       94              
  Lines        5047     5093      +46     
  Branches     1375     1380       +5     
==========================================
+ Hits         4546     4589      +43     
- Misses        249      251       +2     
- Partials      252      253       +1     
Impacted Files Coverage Δ
src/card/index.tsx 100.00% <100.00%> (ø)
src/dialog/index.tsx 100.00% <100.00%> (ø)
src/header/index.tsx 100.00% <100.00%> (ø)
src/result/index.tsx 90.32% <100.00%> (+1.86%) :arrow_up:
src/snackbar/index.tsx 100.00% <100.00%> (ø)
src/loading-indicator/index.tsx 88.46% <0.00%> (-11.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 650a556...c5b55c8. Read the comment docs.

agubler commented 3 years ago

Closing for now while we determine the best / most consistent approach for actions within the lib