dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

1655 - Typeahead / Select Placeholder #1718

Open KaneFreeman opened 3 years ago

KaneFreeman commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description: Add placeholder input for typeahead and select, add default option when required is false

Resolves #1655

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/3XessanKdWC9EC1y6gi7LANtmpuQ
βœ… Preview: https://widget-test-do-git-fork-kanefreeman-bugfix-select-typeah-369d97.vercel.app

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/ABmYkjdDGRxiV2MfL6TC5NngLBxn
βœ… Preview: https://dojowidgets-git-fork-kanefreeman-bugfix-select-typeah-0d8289.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1718 (5c1bd28) into master (d543a3f) will increase coverage by 0.09%. The diff coverage is 92.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1718      +/-   ##
==========================================
+ Coverage   90.43%   90.53%   +0.09%     
==========================================
  Files          94       94              
  Lines        5143     5175      +32     
  Branches     1403     1415      +12     
==========================================
+ Hits         4651     4685      +34     
+ Misses        241      237       -4     
- Partials      251      253       +2     
Impacted Files Coverage Ξ”
src/typeahead/index.tsx 85.23% <88.88%> (+2.33%) :arrow_up:
src/select/index.tsx 88.54% <91.30%> (-0.25%) :arrow_down:
src/list/index.tsx 82.08% <100.00%> (+0.42%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update d543a3f...5c1bd28. Read the comment docs.