dojo / widgets

:rocket: Dojo - UI widgets.

https://widgets.dojo.io

Other

88 stars 66 forks source link

1612 - Select rejects bad values #1720

Closed KaneFreeman closed 3 years ago

KaneFreeman commented 3 years ago

Type: bug

The following has been addressed in the PR:

[x] There is a related issue
[x] All code matches the style guide
[x] Unit tests are included in the PR
[ ] For new widgets, an entry has been added to the .dojorc
[ ] For new widgets, theme.variant() is added to the root domnode
[ ] Any widget variant uses theme.compose like this
[ ] WidgetProperties are exported

Description:

If no item can be queried from the resource with the given value:
- Select will no longer display value
- Select will style itself as it empty
Returned query results will be checked against the given value to ensure it matches

Resolves #1612

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/38gMmYPXfxpd4oSEZvDuMaKg9KCs
✅ Preview: https://widget-test-do-git-fork-kanefreeman-bugfix-select-value-b27900.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/8jueZBYQjtHHRJyp1o1rJ1SbwDoZ
✅ Preview: https://dojowidgets-git-fork-kanefreeman-bugfix-select-value-set-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1720 (f4ad933) into master (afc67b0) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1720      +/-   ##
==========================================
+ Coverage   90.17%   90.21%   +0.04%     
==========================================
  Files          94       94              
  Lines        5088     5089       +1     
  Branches     1384     1385       +1     
==========================================
+ Hits         4588     4591       +3     
+ Misses        247      246       -1     
+ Partials      253      252       -1

Impacted Files	Coverage Δ
src/select/index.tsx	`88.79% <100.00%> (+1.83%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afc67b0...f4ad933. Read the comment docs.