dojo / widgets

:rocket: Dojo - UI widgets.

https://widgets.dojo.io

Other

88 stars 66 forks source link

Fix: update date input to use shim padStart #1723

Closed mwistrand closed 3 years ago

mwistrand commented 3 years ago

Type: bug

The following has been addressed in the PR:

[x] There is a related issue
[x] All code matches the style guide
[ ] Unit tests are included in the PR
[ ] For new widgets, an entry has been added to the .dojorc
[ ] For new widgets, theme.variant() is added to the root domnode
[ ] Any widget variant uses theme.compose like this
[ ] WidgetProperties are exported

Description:

Update the formatDateISO function exposed by the date input's utils to use the padStart from @dojo/framework/shim rather than the native String.prototype.padStart that is not supported in IE11.

Resolves #1722

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/12ckRncYZL7MBRWn3ywLH1H3FznM
✅ Preview: https://widget-test-do-git-fork-mwistrand-fix-1722date-input-pad-e0085a.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/EqBB5UaBqF7ok2a12wo5BR2y4je1
✅ Preview: https://dojowidgets-git-fork-mwistrand-fix-1722date-input-pad-96a461.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1723 (abd7c46) into master (afc67b0) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1723   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files          94       94           
  Lines        5088     5089    +1     
  Branches     1384     1384           
=======================================
+ Hits         4588     4589    +1     
  Misses        247      247           
  Partials      253      253

Impacted Files	Coverage Δ
src/date-input/date-utils.tsx	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afc67b0...abd7c46. Read the comment docs.