dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

1609 - Do not set first item as active by default #1724

Closed KaneFreeman closed 3 years ago

KaneFreeman commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description: When no active index is set, no list item is selected instead of the previous behavior of defaulting to the first item.

Resolves #1609

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/4SjVuYk1R7iSjwFuMFiw2PtYnFrL
βœ… Preview: https://widget-test-do-git-fork-kanefreeman-bugfix-1609-first-it-46e74e.vercel.app

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/9LjGM31nXubbGdfGF7PMpfsYMaKh
βœ… Preview: https://dojowidgets-git-fork-kanefreeman-bugfix-1609-first-it-cf4b68.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1724 (cd5cc19) into master (ca3cf63) will increase coverage by 0.10%. The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1724      +/-   ##
==========================================
+ Coverage   90.24%   90.35%   +0.10%     
==========================================
  Files          94       94              
  Lines        5116     5120       +4     
  Branches     1392     1398       +6     
==========================================
+ Hits         4617     4626       +9     
+ Misses        244      243       -1     
+ Partials      255      251       -4     
Impacted Files Coverage Ξ”
src/list/index.tsx 81.65% <94.73%> (+1.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update ca3cf63...cd5cc19. Read the comment docs.