Closed bitpshr closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
π Inspect: https://vercel.com/dojo/dojo.widgets/CzftZDWuq4wWsYro8bggRdd4gQKP
β
Preview: In Progress
π Inspect: https://vercel.com/dojo/widget-test-docs/AEZ6k7nnCwC1Zp7efuUqEuzhAYJk
β
Preview: In Progress
Merging #1725 (85b4ca0) into master (afc67b0) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1725 +/- ##
=======================================
Coverage 90.17% 90.18%
=======================================
Files 94 94
Lines 5088 5093 +5
Branches 1384 1384
=======================================
+ Hits 4588 4593 +5
Misses 247 247
Partials 253 253
Impacted Files | Coverage Ξ | |
---|---|---|
src/time-picker/index.tsx | 82.22% <100.00%> (+0.40%) |
:arrow_up: |
src/date-input/date-utils.tsx | 100.00% <0.00%> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update afc67b0...85b4ca0. Read the comment docs.
Type: bug
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
This pull request fixes an issue when using the
TimePicker
in Safari wherein formatting was offsetting the chosen display value by the locale-specific timezone offset. This issue did not present itself in other browsers becausetoLocaleTimeString
appears to respect the time that's passed to it in all browsers but Safari.Before:
After:
Resolves #1717