dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

The card content needs 100% sizing to work properly on safari #1731

Closed agubler closed 3 years ago

agubler commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description:

Looks like the card content needs 100% width and height as in order to take up all the available space. It works properly in chrome but not in safari/ios.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/5gKa6Cjp4QS6x4woYL3RA5ME8C5J
βœ… Preview: https://widget-test-docs-git-fork-agubler-card-content-sizing-dojo1.vercel.app

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/J8jSmZGMNJrwXu6qPnPMtXMSbtit
βœ… Preview: https://dojowidgets-git-fork-agubler-card-content-sizing-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1731 (745658f) into master (074c28f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1731   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files          94       94           
  Lines        5111     5111           
  Branches     1390     1390           
=======================================
  Hits         4612     4612           
  Misses        246      246           
  Partials      253      253           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 074c28f...745658f. Read the comment docs.