dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

1715 - Change label color on focus instead of on active for material theme #1737

Closed KaneFreeman closed 3 years ago

KaneFreeman commented 3 years ago

Type: bug

The following has been addressed in the PR:

Description: Match label color behavior to material specs. Primary on focus, secondary on blur. Previously it was primary on active which resulted in the label staying the primary color once a value in the parent text input or select was set.

Resolves #1715

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

πŸ” Inspect: https://vercel.com/dojo/widget-test-docs/C6a3ZQ13akPMK4in4TvaocQ5v14g
βœ… Preview: https://widget-test-do-git-fork-kanefreeman-1715-label-text-wron-4a0446.vercel.app

dojo.widgets – ./

πŸ” Inspect: https://vercel.com/dojo/dojo.widgets/96riX77zgfceWrNWmaiVr1Uo7UmW
βœ… Preview: https://dojowidgets-git-fork-kanefreeman-1715-label-text-wron-646294.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1737 (e027107) into master (7fbe4e9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1737   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          94       94           
  Lines        5116     5116           
  Branches     1392     1392           
=======================================
  Hits         4617     4617           
  Misses        244      244           
  Partials      255      255           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 7fbe4e9...e027107. Read the comment docs.