dojo / widgets

:rocket: Dojo - UI widgets.

https://widgets.dojo.io

Other

88 stars 66 forks source link

Fix/chip typeahead styles #1739

Closed bitpshr closed 3 years ago

bitpshr commented 3 years ago

Type: bug

The following has been addressed in the PR:

[x] There is a related issue
[x] All code matches the style guide
[x] Unit tests are included in the PR
[x] For new widgets, an entry has been added to the .dojorc
[x] For new widgets, theme.variant() is added to the root domnode
[x] Any widget variant uses theme.compose like this
[x] WidgetProperties are exported

Description:

This pull request fixes issues with the ChipTypeahead that were introduced by changes to the TextInput leading content configuration.

Resolves #1728

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/7gJcmQ9ixqCHo61YV4CJJjxHTPYT
✅ Preview: https://widget-test-do-git-fork-bitpshr-fix-chip-typeahead-style-01b190.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/BgrB5yn2EFeaT3WnuTqifWg5Phxd
✅ Preview: https://dojowidgets-git-fork-bitpshr-fix-chip-typeahead-styles-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1739 (1121f0a) into master (7fbe4e9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1739   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          94       94           
  Lines        5116     5116           
  Branches     1392     1392           
=======================================
  Hits         4617     4617           
  Misses        244      244           
  Partials      255      255

Impacted Files	Coverage Δ
src/chip-typeahead/index.tsx	`89.71% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7fbe4e9...1121f0a. Read the comment docs.