Closed bitpshr closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
π Inspect: https://vercel.com/dojo/dojo.widgets/8EU68kT3GV6vnsdDo4qTPxe1XJ2i
β
Preview: https://dojowidgets-git-feat-list-item-theming-dojo1.vercel.app
π Inspect: https://vercel.com/dojo/widget-test-docs/HtovuDZQT3JFKDkgcjjNLdQskmeB
β
Preview: https://widget-test-docs-git-feat-list-item-theming-dojo1.vercel.app
Merging #1744 (d7658b6) into master (4b0ce16) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1744 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 94 94
Lines 5116 5116
Branches 1392 1392
=======================================
Hits 4617 4617
Misses 244 244
Partials 255 255
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 4b0ce16...d7658b6. Read the comment docs.
What do you think to adding an example? We should be able to demonstrate this by rendering a list with the variant="inherit"
property in a wrapping node that has a class that changes the definition of the new variables π
I think you can define them inline over the class, which will be super clear in the example of what is going on.
Sorry @bitpshr forgot to mention you in the comment above ^
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
This pull request updates the
ListItem
by adding background and color variables to applicable states (disabled, active, selected) so that it can be themed independently of other widgets.Resolves #1726