dojo / widgets

:rocket: Dojo - UI widgets.

https://widgets.dojo.io

Other

88 stars 66 forks source link

feat: easier list item theming #1744

Closed bitpshr closed 3 years ago

bitpshr commented 3 years ago

Type: feature

The following has been addressed in the PR:

[x] There is a related issue
[x] All code matches the style guide
[x] Unit tests are included in the PR
[x] For new widgets, an entry has been added to the .dojorc
[x] For new widgets, theme.variant() is added to the root domnode
[x] Any widget variant uses theme.compose like this
[x] WidgetProperties are exported

Description:

This pull request updates the ListItem by adding background and color variables to applicable states (disabled, active, selected) so that it can be themed independently of other widgets.

Resolves #1726

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/8EU68kT3GV6vnsdDo4qTPxe1XJ2i
✅ Preview: https://dojowidgets-git-feat-list-item-theming-dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/HtovuDZQT3JFKDkgcjjNLdQskmeB
✅ Preview: https://widget-test-docs-git-feat-list-item-theming-dojo1.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1744 (d7658b6) into master (4b0ce16) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1744   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          94       94           
  Lines        5116     5116           
  Branches     1392     1392           
=======================================
  Hits         4617     4617           
  Misses        244      244           
  Partials      255      255

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b0ce16...d7658b6. Read the comment docs.

agubler commented 3 years ago

What do you think to adding an example? We should be able to demonstrate this by rendering a list with the variant="inherit" property in a wrapping node that has a class that changes the definition of the new variables 😄

I think you can define them inline over the class, which will be super clear in the example of what is going on.

agubler commented 3 years ago

Sorry @bitpshr forgot to mention you in the comment above ^