dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

feat: add disabled prop to radio and checkbox groups #1745

Closed bitpshr closed 3 years ago

bitpshr commented 3 years ago

Type: bug / feature

The following has been addressed in the PR:

Description:

This pull request adds a top-level disabled prop to both CheckboxGroup and RadioGroup and updates tests accordingly.

Resolves #1698 Replaces #1711

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/FLqGJcjWu8BifbuwQthNUDFg7e4D
✅ Preview: https://dojowidgets-git-fork-bitpshr-feat-checkbox-radio-grou-66763d.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/2B5V6i9grqxPrBNiGspekvaK9pav
✅ Preview: https://widget-test-do-git-fork-bitpshr-feat-checkbox-radio-grou-878bef.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #1745 (aaa9553) into master (4b0ce16) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1745      +/-   ##
==========================================
+ Coverage   90.24%   90.36%   +0.12%     
==========================================
  Files          94       94              
  Lines        5116     5129      +13     
  Branches     1392     1398       +6     
==========================================
+ Hits         4617     4635      +18     
+ Misses        244      243       -1     
+ Partials      255      251       -4     
Impacted Files Coverage Δ
src/checkbox-group/index.tsx 100.00% <100.00%> (ø)
src/radio-group/index.tsx 100.00% <100.00%> (ø)
src/context-menu/index.tsx 100.00% <0.00%> (ø)
src/speed-dial/index.tsx 97.52% <0.00%> (+0.08%) :arrow_up:
src/list/index.tsx 81.65% <0.00%> (+1.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b0ce16...aaa9553. Read the comment docs.