Closed agubler closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/dojo/dojo.widgets/489SpjxfVr5p2DfoSffM6M2J6Ppu
✅ Preview: https://dojowidgets-git-fork-agubler-widget-names-dojo1.vercel.app
🔍 Inspect: https://vercel.com/dojo/widget-test-docs/DBbRDdfcFyhd1iagJ46uCHzxL6Df
✅ Preview: https://widget-test-docs-git-fork-agubler-widget-names-dojo1.vercel.app
Merging #1746 (2cc09a7) into master (c6f4cda) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
+ Coverage 90.24% 90.25% +0.01%
==========================================
Files 94 94
Lines 5116 5123 +7
Branches 1392 1392
==========================================
+ Hits 4617 4624 +7
Misses 244 244
Partials 255 255
Impacted Files | Coverage Δ | |
---|---|---|
src/checkbox-group/index.tsx | 100.00% <100.00%> (ø) |
|
src/context-menu/index.tsx | 100.00% <100.00%> (ø) |
|
src/email-input/index.tsx | 84.21% <100.00%> (ø) |
|
src/form/index.tsx | 98.00% <100.00%> (ø) |
|
src/radio-group/index.tsx | 100.00% <100.00%> (ø) |
|
src/rate/index.tsx | 85.52% <100.00%> (ø) |
|
src/speed-dial/index.tsx | 97.52% <100.00%> (+0.08%) |
:arrow_up: |
src/three-column-layout/index.tsx | 87.50% <100.00%> (ø) |
|
src/two-column-layout/index.tsx | 95.23% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c6f4cda...2cc09a7. Read the comment docs.
Type: bug
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
Fixes a few missing or incorrect widget names across the library. Widget names are very useful as they are used by the test renderer to show diffs for failing tests.