dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

feat: file upload #1749

Open bitpshr opened 3 years ago

bitpshr commented 3 years ago

Type: feature

The following has been addressed in the PR:

Description:

This pull request introduces two new widgets to help support file uploads, FileUploadInput for simple uploads, and FileUploader for more complex upload management.

Resolves #1129 Replaces #1540

Preview

Screen Shot 2021-05-07 at 9 07 52 AM Screen Shot 2021-05-07 at 9 07 34 AM
vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/Db2mP9AuBtAmjncLajjSAdngV2cV
✅ Preview: Failed

[Deployment for 2c345ba failed]

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/Bivv4DTqhp2NbFkPFZwDUXgusUhF
✅ Preview: Failed

[Deployment for 2c345ba failed]

codecov[bot] commented 3 years ago

Codecov Report

Merging #1749 (2c345ba) into master (7c8e49e) will decrease coverage by 0.14%. The diff coverage is 84.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   90.46%   90.32%   -0.15%     
==========================================
  Files          94       98       +4     
  Lines        5152     5284     +132     
  Branches     1406     1445      +39     
==========================================
+ Hits         4661     4773     +112     
- Misses        241      250       +9     
- Partials      250      261      +11     
Impacted Files Coverage Δ
src/file-upload-input/index.tsx 80.00% <80.00%> (ø)
src/file-uploader/index.tsx 86.36% <86.36%> (ø)
src/file-upload-input/nls/FileUploadInput.ts 100.00% <100.00%> (ø)
src/file-uploader/nls/FileUploader.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c8e49e...2c345ba. Read the comment docs.

msssk commented 3 years ago

Why was DnD dropped? That seems like a key feature of a file upload widget.

I don't see that .dojorc was updated - if this is no longer necessary we should remove it from our PR template.

bitpshr commented 3 years ago

@msssk I chose to remove drag-and-drop for this first version of the file upload components since it adds a lot of complexity. I agree that it's a nice to have feature (though getting less common in practice) but I don't think it's required to accomplish the end goal of uploading files and managing them.

agubler commented 3 years ago

@bitpshr there seems to be typescript errors