Bug: Check span value in diff property

[agubler]

Type: bug

The following has been addressed in the PR:

• [ ] There is a related issue
• [x] All code matches the style guide
• [ ] Unit tests are included in the PR
• [ ] For new widgets, an entry has been added to the .dojorc
• [ ] For new widgets, theme.variant() is added to the root domnode
• [ ] Any widget variant uses theme.compose like this
• [ ] WidgetProperties are exported

Description:

diffProperty needs to actually do the diff on the span property to determine if the callback needs to be called. Otherwise the the callback is called every time and ends up with causing an infinite render loop.

[vercel[bot]]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/EinhYyZwsWpDZNzLDpG7kdAiz8kg
✅ Preview: https://widget-test-docs-git-fork-agubler-stack-renderes-dojo1.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/49t1oCb34CkHb54HaWfx3JgKUQyj
✅ Preview: https://dojowidgets-git-fork-agubler-stack-renderes-dojo1.vercel.app

[codecov[bot]]

Codecov Report

Merging #1750 (2f42ae8) into master (9d94b19) will decrease coverage by 0.01%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1750      +/-   ##
==========================================
- Coverage   90.57%   90.55%   -0.02%     
==========================================
  Files          96       96              
  Lines        5218     5220       +2     
  Branches     1418     1419       +1     
==========================================
+ Hits         4726     4727       +1     
  Misses        241      241              
- Partials      251      252       +1     

Impacted Files	Coverage Δ
src/stack/index.tsx	98.24% <66.66%> (-1.76%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d94b19...2f42ae8. Read the comment docs.