Closed agubler closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/dojo/widget-test-docs/7KG6219xseo9uQp3AuRNHAs33HKx
✅ Preview: https://widget-test-docs-git-fork-agubler-proper-kinds-dojo1.vercel.app
🔍 Inspect: https://vercel.com/dojo/dojo.widgets/5QDYMw6jSbPjxLb8hE63fyvKFi3M
✅ Preview: https://dojowidgets-git-fork-agubler-proper-kinds-dojo1.vercel.app
Merging #1751 (4d121b0) into master (d09d090) will decrease coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1751 +/- ##
==========================================
- Coverage 90.55% 90.54% -0.02%
==========================================
Files 96 94 -2
Lines 5220 5193 -27
Branches 1419 1418 -1
==========================================
- Hits 4727 4702 -25
Misses 241 241
+ Partials 252 250 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/floating-action-button/index.tsx | 100.00% <ø> (ø) |
|
src/accordion/index.tsx | 100.00% <100.00%> (ø) |
|
src/button/index.tsx | 86.79% <100.00%> (+3.15%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d09d090...4d121b0. Read the comment docs.
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
This change repurposes the
kind
property of theButton
to define the actual different kinds of button i.e.outlined
,text
andcontained
as per the material spec. The existing behaviour forkind
in the button has been removed, as the primary and secondary colour are not a "kind". In the future we will look at whether we implement a property to control colour.kind
will be the consistent approach to supporting variants such as outlined, and will update the card and other places to reflect this.This is a breaking changes as RaisedButton and OutlinedButton no longer exist and the default button style is Contained (aka Raised).