Closed KaneFreeman closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
π Inspect: https://vercel.com/dojo/widget-test-docs/CgEctCeuSJACBaG2x9WvKodf81EV
β
Preview: https://widget-test-docs-git-fork-kanefreeman-feature-outl-f7d95a-dojo1.vercel.app
π Inspect: https://vercel.com/dojo/dojo.widgets/4t9xmHhxSp5sZsHNFZ9k8sxFophf
β
Preview: https://dojowidgets-git-fork-kanefreeman-feature-outlined-input-dojo1.vercel.app
Merging #1756 (2df3fb9) into master (05f2d0a) will increase coverage by
0.03%
. The diff coverage is89.70%
.
@@ Coverage Diff @@
## master #1756 +/- ##
==========================================
+ Coverage 90.57% 90.61% +0.03%
==========================================
Files 95 95
Lines 5232 5262 +30
Branches 1429 1450 +21
==========================================
+ Hits 4739 4768 +29
Misses 241 241
- Partials 252 253 +1
Impacted Files | Coverage Ξ | |
---|---|---|
src/text-input/index.tsx | 92.70% <84.61%> (+0.01%) |
:arrow_up: |
src/text-area/index.tsx | 80.95% <95.00%> (+2.57%) |
:arrow_up: |
src/chip-typeahead/index.tsx | 89.52% <100.00%> (-0.20%) |
:arrow_down: |
src/date-input/index.tsx | 91.45% <100.00%> (+0.07%) |
:arrow_up: |
src/time-picker/index.tsx | 82.41% <100.00%> (ΓΈ) |
|
src/typeahead/index.tsx | 83.04% <100.00%> (+0.14%) |
:arrow_up: |
src/stack/index.tsx | 98.24% <0.00%> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 05f2d0a...2df3fb9. Read the comment docs.
@KaneFreeman Looks solid for these inputs, but we do need to add the same to Select and ChipTypeahead as well as they are inputs too.
The styling for the existing chip-typeahead seems to have been affected by the changes too https://widget-test-do-git-fork-kanefreeman-feature-outlined-inp-f7d95a.vercel.app/#widget/chip-typeahead/overview
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription: Add outlined option "kind" to
text-input
andtext-area
widgetsText Input![text-input](https://user-images.githubusercontent.com/1388138/120851196-7ec2a480-c546-11eb-9f9f-fd528a70bc8d.gif)
Text Area![text-area](https://user-images.githubusercontent.com/1388138/120851205-81bd9500-c546-11eb-8bda-b71c48178096.gif)
Resolves #1752