dojo / widgets

:rocket: Dojo - UI widgets.
https://widgets.dojo.io
Other
88 stars 66 forks source link

Radio / Check buttons have no background color #352

Closed tomdye closed 6 years ago

tomdye commented 6 years ago

Bug

Radio and Check buttons have no background color, so the color they are placed on bleeds through, this may be intentional.

screenshot 2017-11-01 17 24 03

tomdye commented 6 years ago

@smhigley @bitpshr thoughts please?

smhigley commented 6 years ago

It was intentional on my part, but I don't have strong opinions either way. I'd defer to Scott on his preference

tomdye commented 6 years ago

Looks like we're setting a background colour for the toggle and for the thumb on the slider, so I guess I'd expect these to follow suit?

smhigley commented 6 years ago

It would help protect contrast, so there's that. Toggle and the slider thumb seem a little more separate from the page background to me, but that's pretty subjective. Again, I don't care much either way :)

tomdye commented 6 years ago

for clarity i'm only talking about the radio button itself, not the label

smhigley commented 6 years ago

I figured, since I'd have to question your sanity if you were talking about the label 😆. For this one, I'm fine going ahead and making the background white. I think tabs should have a look from Scott though, since it's a more prominent difference.

bitpshr commented 6 years ago

As a downstream user, I wouldn't expect to have to style the background color of my radio button to use it on a non-white background, so +1 for being explicit with white.

smhigley commented 6 years ago

Background color added in #358