Closed tomdye closed 6 years ago
@smhigley @bitpshr thoughts please?
It was intentional on my part, but I don't have strong opinions either way. I'd defer to Scott on his preference
Looks like we're setting a background colour for the toggle and for the thumb on the slider, so I guess I'd expect these to follow suit?
It would help protect contrast, so there's that. Toggle and the slider thumb seem a little more separate from the page background to me, but that's pretty subjective. Again, I don't care much either way :)
for clarity i'm only talking about the radio button itself, not the label
I figured, since I'd have to question your sanity if you were talking about the label 😆. For this one, I'm fine going ahead and making the background white. I think tabs should have a look from Scott though, since it's a more prominent difference.
As a downstream user, I wouldn't expect to have to style the background color of my radio button to use it on a non-white background, so +1 for being explicit with white.
Background color added in #358
Bug
Radio and Check buttons have no background color, so the color they are placed on bleeds through, this may be intentional.